fix: return 400 on duplicate logger name in PUT /api/logger/:id#710
fix: return 400 on duplicate logger name in PUT /api/logger/:id#710aabhinavvvvvvv wants to merge 8 commits into
Conversation
aabhinavvvvvvv
force-pushed
the
fix/issue-626-duplicate-logger-name
branch
from
a331820 to
48b87df
Compare
|
/deploy |
|
PR deployed to development server Commit: 710 Triggered by: @jmadden173 |
jmadden173
left a comment
jmadden173
left a comment
There was a problem hiding this comment.
The implementation looks good.
TODOs:
- a unit test for the case
- adding a line in the changelog linking to the issue.
- Fix merge conflicts
- Get the linter to pass
Also adds CHANGELOG entry for jlab-sensing#710. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
Also adds CHANGELOG entry for jlab-sensing#710.
aabhinavvvvvvv
force-pushed
the
fix/issue-626-duplicate-logger-name
branch
from
9d4205a to
ce4cd20
Compare
aabhinavvvvvvv
force-pushed
the
fix/issue-626-duplicate-logger-name
branch
from
ce4cd20 to
f1d99e9
Compare
|
@jmadden173 The workflow uses pull_request_target with a plain actions/checkout@v6 and this checks out the BASE branch (upstream/main), not our PR branch. So black is always running on upstream/main's code, and upstream/main has #from api.models.user import User (without space) in test_cell.py. |
|
@jmadden173 All our tests pass (63/64). The only failure is test_get_teros_obj_fraction_scales_to_percent which is a pre-existing bug unrelated to this PR — TEROSData.get_teros_data_obj() no longer returns a vwc_unit key that the test expects. This failure exists in jlab-sensing:main independently of our changes. |
|
Yes I see that, I did not realize how the pull request target was working when I applied that fix. |
2 participants
Summary
Fixes #626 — renaming a logger to a duplicate name caused the server to hang with no feedback shown to the user.
Changes:
backend/api/resources/logger.py— Duplicate name check inPUThandler, now returns400immediately instead of hanging.frontend/src/pages/profile/components/EditLoggerModal.jsx— Show error message inline when update fails.backend/api/schemas/cell_schema.py— Fix marshmallow 4 startup crash (missingUserimport).Demo
ents_logger.mp4